Restrict InspectClass to current thread.

If there are other threads asking for class restransformation InspectClass may be called during the transient period of time when the callback is enabled. More importantly InspectClass could be called after jvmti env is disposed, which would lead to native crashes. This should fix issue linkedin#134.
ttanxu · Jan 23, 2019 · c70e552 · c70e552
1 parent e65b7ce
commit c70e552
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...o-inline-extended/src/main/java/com/android/dx/mockito/inline/StaticMockMethodAdvice.java b/...o-inline-extended/src/main/java/com/android/dx/mockito/inline/StaticMockMethodAdvice.java
@@ -152,7 +152,7 @@ private static List<Class<?>> getAllSubclasses(Class<?> superClass, Collection<C
         return subclasses;
     }
 
-    private synchronized static native String nativeGetCalledClassName();
+    private synchronized static native String nativeGetCalledClassName(Thread currentThread);
 
     private Class<?> getClassMethodWasCalledOn(MethodDesc methodDesc) throws ClassNotFoundException,
             NoSuchMethodException {
@@ -183,7 +183,7 @@ private Class<?> getClassMethodWasCalledOn(MethodDesc methodDesc) throws ClassNo
                 return null;
             }
 
-            String calledClassName = nativeGetCalledClassName();
+            String calledClassName = nativeGetCalledClassName(Thread.currentThread());
             return Class.forName(calledClassName);
         }
     }

diff --git a/dexmaker-mockito-inline-extended/src/main/jni/staticjvmtiagent/agent.cc b/dexmaker-mockito-inline-extended/src/main/jni/staticjvmtiagent/agent.cc
@@ -747,7 +747,9 @@ namespace com_android_dx_mockito_inline {
 
     extern "C" JNIEXPORT jstring JNICALL
     Java_com_android_dx_mockito_inline_StaticMockMethodAdvice_nativeGetCalledClassName(JNIEnv* env,
-                                                                                     jclass klass) {
+                                                                            jclass klass,
+                                                                            jthread currentThread) {
+
         JavaVM *vm;
         jint jvmError = env->GetJavaVM(&vm);
         if (jvmError != JNI_OK) {
@@ -804,7 +806,7 @@ namespace com_android_dx_mockito_inline {
         GOTO_ON_ERROR(unregister_env_and_exit);
 
         error = jvmtiEnv->SetEventNotificationMode(JVMTI_ENABLE, JVMTI_EVENT_CLASS_FILE_LOAD_HOOK,
-                                                   nullptr);
+                                                   currentThread);
         GOTO_ON_ERROR(unset_cb_and_exit);
 
         frameToInspect = &frameInfo[callingFrameNum];
@@ -813,7 +815,7 @@ namespace com_android_dx_mockito_inline {
 
         disable_hook_and_exit:
         jvmtiEnv->SetEventNotificationMode(JVMTI_DISABLE, JVMTI_EVENT_CLASS_FILE_LOAD_HOOK,
-                                           nullptr);
+                                           currentThread);
 
         unset_cb_and_exit:
         memset(&cb, 0, sizeof(cb));