This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
fix: parse power value for new Firmware Version (v2.0.0+) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed error logging
Added test script
Fixed test script
… state before reaching the minimumTime threshold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
developmentbranch wasn't up to date withmainwhich is why the changes seem to be quite comprehensive.Following changes (compared to
main) have been done:statusObjectchanged in v2.0.0)minimumTimeis now compared with the last pulled state change (instead of the last persisted state change)Please review the changes carefully since I am uncertain if I understood the intention of the original implementation correctly.
Let me know if there are any questions!