Skip to content

Commit

Permalink
added comments, updated TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
Max Weidauer committed Oct 8, 2024
1 parent 383c81a commit 3a51c96
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions SeamLess_Client/source/PluginProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,13 @@ juce::AudioProcessor* JUCE_CALLTYPE createPluginFilter()
}

void AudioPluginAudioProcessor::parameterChanged(const juce::String &parameterID, float newValue) {
// This callback is called when any of the automatable OSC params is changed
pluginConnection.parameterChanged(parameterID, newValue);

}

void AudioPluginAudioProcessor::valueTreePropertyChanged(juce::ValueTree &treeWhosePropertyHasChanged, const juce::Identifier &property) {
// This callback is called when the source_index is changed
pluginConnection.parameterChanged(property.toString(), treeWhosePropertyHasChanged.getProperty(property));
}

Expand Down
2 changes: 1 addition & 1 deletion TODO.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# TODO

- [ ] fix bug that ableton live does not recall the state of the plugin with notautomatable parameters
- [ ] Limitation, that every source index can only exist once.
- [ ] Tooltips!
- [x] Send interval OSC limitation Main
Expand All @@ -27,3 +26,4 @@
when moving in the xy-pad, x and y are updated seperately. This also triggers two seperate calls to `SphericalSliderBox::updateSphericalCoordinates()`, one with the new x and the old y, and one with the new y and old x. only the second update is used to actually update the values, so when just clicking anywhere on the xy-pad once, it often leads to discontinuities.
**Solution**: bundle updates together, or only update single coordinates at a time, or internally keep track of state
- [ ] move cartesian-coordinate-limit from sphericalsliderbox to a global setting
- [ ] listen to spherical coordinates via OSC

0 comments on commit 3a51c96

Please sign in to comment.