Skip to content

Commit

Permalink
Change CLI fileExtension to nil
Browse files Browse the repository at this point in the history
The fileExtension property is used upstream to determine the
explicitFileType of the file reference. If that property exists but is
empty Xcode crashes. Previously that was the case with the tool file
type since the product target had an empty explicitFileType. With this
change it now omits that property instead, and still has no extension.
  • Loading branch information
keith committed Dec 27, 2017
1 parent 20a9e0f commit 9b53b5b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## next version

### Fixed
- macOS CLI targets now have a nil extension, instead of an empty string https://github.com/xcodeswift/xcproj/pull/208 by @keith

## 2.0.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXProductType.swift
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public enum PBXProductType: String, Decodable {
case .appExtension, .tvExtension, .watchExtension, .watch2Extension, .messagesExtension, .stickerPack, .xcodeExtension:
return "appex"
case .commandLineTool:
return ""
return nil
case .xpcService:
return "xpc"
case .ocUnitTestBundle:
Expand Down

0 comments on commit 9b53b5b

Please sign in to comment.