Add disablePerformanceAntipatternChecker to scheme (#694)

* Add disablePerformanceAntipatternChecker to LaunchAction * Cover with tests disablePerformanceAntipatternChecker action * Update CHANGELOG.md - Add entry about adding `disablePerformanceAntipatternChecker` action
tuist · Jun 30, 2022 · e02240f · e02240f
1 parent 2fe19ca
commit e02240f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Next
 
+### Added
+
+- Added `disablePerformanceAntipatternChecker` to `XCScheme` [#693](https://github.com/tuist/XcodeProj/pull/603) by [@Bogdan-Belogurov](https://github.com/Bogdan-Belogurov)
+
 ## 8.7.1
 
 ### Changed

diff --git a/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift b/Sources/XcodeProj/Scheme/XCScheme+LaunchAction.swift
@@ -57,6 +57,7 @@ extension XCScheme {
         public var enableUBSanitizer: Bool
         public var stopOnEveryUBSanitizerIssue: Bool
         public var disableMainThreadChecker: Bool
+        public var disablePerformanceAntipatternChecker: Bool
         public var stopOnEveryMainThreadCheckerIssue: Bool
         public var additionalOptions: [AdditionalOption]
         public var commandlineArguments: CommandLineArguments?
@@ -96,6 +97,7 @@ extension XCScheme {
                     enableUBSanitizer: Bool = false,
                     stopOnEveryUBSanitizerIssue: Bool = false,
                     disableMainThreadChecker: Bool = false,
+                    disablePerformanceAntipatternChecker: Bool = false,
                     stopOnEveryMainThreadCheckerIssue: Bool = false,
                     additionalOptions: [AdditionalOption] = [],
                     commandlineArguments: CommandLineArguments? = nil,
@@ -129,6 +131,7 @@ extension XCScheme {
             self.enableUBSanitizer = enableUBSanitizer
             self.stopOnEveryUBSanitizerIssue = stopOnEveryUBSanitizerIssue
             self.disableMainThreadChecker = disableMainThreadChecker
+            self.disablePerformanceAntipatternChecker = disablePerformanceAntipatternChecker
             self.stopOnEveryMainThreadCheckerIssue = stopOnEveryMainThreadCheckerIssue
             self.additionalOptions = additionalOptions
             self.commandlineArguments = commandlineArguments
@@ -191,6 +194,7 @@ extension XCScheme {
             enableUBSanitizer = element.attributes["enableUBSanitizer"] == "YES"
             stopOnEveryUBSanitizerIssue = element.attributes["stopOnEveryUBSanitizerIssue"] == "YES"
             disableMainThreadChecker = element.attributes["disableMainThreadChecker"] == "YES"
+            disablePerformanceAntipatternChecker = element.attributes["disablePerformanceAntipatternChecker"] == "YES"
             stopOnEveryMainThreadCheckerIssue = element.attributes["stopOnEveryMainThreadCheckerIssue"] == "YES"
 
             additionalOptions = try element["AdditionalOptions"]["AdditionalOption"]
@@ -267,6 +271,9 @@ extension XCScheme {
             if disableMainThreadChecker {
                 attributes["disableMainThreadChecker"] = disableMainThreadChecker.xmlString
             }
+            if disablePerformanceAntipatternChecker {
+                attributes["disablePerformanceAntipatternChecker"] = disablePerformanceAntipatternChecker.xmlString
+            }
             if stopOnEveryMainThreadCheckerIssue {
                 attributes["stopOnEveryMainThreadCheckerIssue"] = stopOnEveryMainThreadCheckerIssue.xmlString
             }
@@ -365,6 +372,7 @@ extension XCScheme {
                 enableUBSanitizer == rhs.enableUBSanitizer &&
                 stopOnEveryUBSanitizerIssue == rhs.stopOnEveryUBSanitizerIssue &&
                 disableMainThreadChecker == rhs.disableMainThreadChecker &&
+                disablePerformanceAntipatternChecker == rhs.disablePerformanceAntipatternChecker &&
                 stopOnEveryMainThreadCheckerIssue == rhs.stopOnEveryMainThreadCheckerIssue &&
                 additionalOptions == rhs.additionalOptions &&
                 commandlineArguments == rhs.commandlineArguments &&

diff --git a/Tests/XcodeProjTests/Scheme/XCSchemeTests.swift b/Tests/XcodeProjTests/Scheme/XCSchemeTests.swift
@@ -460,6 +460,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
         XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
         XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
+        XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
         XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)
 
@@ -544,6 +545,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
         XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
         XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
+        XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
         XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)
         XCTAssertNil(scheme.launchAction?.storeKitConfigurationFileReference)
@@ -636,6 +638,7 @@ final class XCSchemeIntegrationTests: XCTestCase {
         XCTAssertEqual(scheme.launchAction?.enableUBSanitizer, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryUBSanitizerIssue, false)
         XCTAssertEqual(scheme.launchAction?.disableMainThreadChecker, false)
+        XCTAssertEqual(scheme.launchAction?.disablePerformanceAntipatternChecker, false)
         XCTAssertEqual(scheme.launchAction?.stopOnEveryMainThreadCheckerIssue, false)
         XCTAssertEqual(scheme.launchAction?.additionalOptions.isEmpty, true)
         XCTAssertNil(scheme.launchAction?.storeKitConfigurationFileReference)