No default lastKnownFileType #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested changes
Oct 30, 2017
There was a problem hiding this comment.
Just a few comment. Would be great to get some input from @yonaskolb who introduced this change.
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| 🚀 Check out the guidelines [here](https://github.com/xcodeswift/contributors/blob/master/CHANGELOG_GUIDELINES.md) | |||
|
|
|||
| ## master | |||
There was a problem hiding this comment.
These changes are not necessary. We'll tag this PR with the proper milestone and we'll update the Changelog accordingly when we make the next release.
| @@ -52,7 +52,7 @@ public class PBXFileReference: PBXObject, Hashable { | |||
| xcLanguageSpecificationIdentifier: String? = nil) { | |||
| self.fileEncoding = fileEncoding | |||
| self.explicitFileType = explicitFileType | |||
| self.lastKnownFileType = lastKnownFileType ?? path.flatMap { PBXFileReference.fileType(path: Path($0)) } | |||
| self.lastKnownFileType = lastKnownFileType | |||
There was a problem hiding this comment.
What are your thoughts on this @yonaskolb?
There was a problem hiding this comment.
I guess if that' really the case. I can see why removing this might be good for other reasons as well, where we might be calculating the wrong lastKnownFileType as PBXFileReference.fileType( would never be perfect
toshi0383
force-pushed
the
ts-no-default-lastknownfiletype
branch
from
e143d41 to
18bef4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Reverts auto calculation of
lastKnownFileTypeintroduced in #58.Solution 📦
It turns out that Xcode sets
explicitFileTypeinstead oflastKnownFileTypefor macOS app target automatically. So we shouldn't set default value for that.