Fixes PBXObject equality #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
approved these changes
Jan 30, 2018
|
@pepibumur do you know why the tests are failing? |
|
@yonaskolb, apparently there are some tests that are failing: |
yonaskolb
commented
Feb 12, 2018
| @@ -22,7 +22,7 @@ final class PBXRezBuildPhaseSpec: XCTestCase { | |||
| } | |||
|
|
|||
| func test_equals_returnsTheCorrectValue() { | |||
| let another = PBXResourcesBuildPhase(files: ["123"], | |||
| let another = PBXRezBuildPhase(files: ["123"], | |||
There was a problem hiding this comment.
This is an example of something that was incorrectly passing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #223
This makes PBXObject conform to
Equatablewhich then calls out to an instance method that all subclasses override. When we move to Sourcery we can remove all of thisThis change is