Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff fixes #233

Merged
merged 3 commits into from
Feb 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Fix Carthage support https://github.com/xcodeswift/xcproj/pull/226 by @ileitch
- Fix adding file reference to bundle and package files https://github.com/xcodeswift/xcproj/pull/234 by @fuzza
- Fix adding PBXGroup without folder reference https://github.com/xcodeswift/xcproj/pull/235 by @fuzza
- Fixed some more diffs from Xcode https://github.com/xcodeswift/xcproj/pull/233 by @yonaskolb

### Changed
- Carthage minimum Deployment Target https://github.com/xcodeswift/xcproj/pull/229 by @olbrichj
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
compatibilityVersion = "Xcode 8.0";
developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
);
mainGroup = E4C06A7B1FC1CA8500A9AB51;
productRefGroup = E4C06A7B1FC1CA8500A9AB51;
projectDirPath = "";
Expand Down
5 changes: 4 additions & 1 deletion Sources/xcproj/PBXProject.swift
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,11 @@ extension PBXProject: PlistSerializable {
dictionary["developmentRegion"] = .string(CommentedString(developmentRegion))
}
dictionary["hasScannedForEncodings"] = .string(CommentedString("\(hasScannedForEncodings)"))
dictionary["knownRegions"] = PlistValue.array(knownRegions

if !knownRegions.isEmpty {
dictionary["knownRegions"] = PlistValue.array(knownRegions
.map {.string(CommentedString("\($0)")) })
}

dictionary["mainGroup"] = .string(CommentedString(mainGroup))
if let productRefGroup = productRefGroup {
Expand Down