Fix adding file reference to bundle and package files #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
- Replace check `isFile` with `exists` for a filePath in `addFile` method defined in PBXProjObjects+Helpers.swift - Add checks for supported files based on PBXFileReference's `fileTypeHash` - Add some more test cases Misc: - Add XCTAssertThrowsSpecificError assert to check if specific error was thrown
fuzza
force-pushed
the
fix/adding-framework-files
branch
from
e7a718e to
88e37ea
Compare
fuzza
changed the title
fuzza
force-pushed
the
fix/adding-framework-files
branch
from
cfc5cca to
87bd1bc
Compare
|
🎉 |
added 2 commits
February 12, 2018 19:56
fuzza
force-pushed
the
fix/adding-framework-files
branch
from
87bd1bc to
d9349ed
Compare
yonaskolb
reviewed
Feb 12, 2018
| } | ||
|
|
||
| guard let fileType = PBXFileReference.fileType(path: filePath) else { |
There was a problem hiding this comment.
I don't think we should require that it's a file we know about. PBXFileReference.fileType isn't an exhaustive list of every possible file, and explicitFileType and lastKnownFileType are optional properties anyway that get filled in by Xcode when the project is opened.
added 2 commits
February 13, 2018 10:51
|
@yonaskolb fixed |
|
Congrats on merging your first pull request! We here at xcode.swift are proud of you! Join our slack channel to talk to other contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Resolves #230
Solution 📦
As it was discussed in original issue,
addFilemethod ofPBXProjObjects+Helpers.swiftnow checks an existence of a file by given path.Implementation 👩💻👨💻
isFilewithexistsfor a filePath inaddFilemethodMisc:
thrown
Review notes
XCodeProjEditingErrorenum was changed in this PR, please review if it should be considered as a breaking change.This change is