Fix Writing of showEnvVarsInLog #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantkelley
force-pushed
the
showEnvVarsInLog
branch
from
bac2fdf to
599aa16
Compare
pepicrft
reviewed
Mar 7, 2018
| @@ -117,7 +117,10 @@ extension PBXShellScriptBuildPhase: PlistSerializable { | |||
| if let shellScript = shellScript { | |||
| dictionary["shellScript"] = .string(CommentedString(shellScript)) | |||
| } | |||
| dictionary["showEnvVarsInLog"] = .string(CommentedString("\(showEnvVarsInLog.int)")) | |||
| if !showEnvVarsInLog { | |||
There was a problem hiding this comment.
What about adding a test that tests this behaviour?
pepicrft
approved these changes
Mar 7, 2018
briantkelley
force-pushed
the
showEnvVarsInLog
branch
from
599aa16 to
261a8d7
Compare
Xcode writes showEnvVarsInLog to the pbxproj file if it’s set to false. If it’s true it’s omitted. Update xcproj to use the same behavior to eliminate diffs when round tripping Xcode projects. This requires defaulting to true when decoding the project file if the key is omitted. I also updated the default parameter in the initializer to true for good measure.
briantkelley
force-pushed
the
showEnvVarsInLog
branch
from
5014c26 to
177dff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Xcode writes showEnvVarsInLog to the pbxproj file if it’s set to false. If it’s true, it’s omitted.
Solution 📦
Update xcproj to use the same behavior as Xcode to eliminate diffs when round tripping Xcode projects.
This requires defaulting to true when decoding the project file if the key is omitted. I also updated the default parameter in the initializer to true for good measure.
Implementation 👩💻👨💻
This change is