Target Xcode 9.3

[LinusU]

Opening this for early feedback

There are probably some more things to do, and I need to fix the tests (would love some pointers on fixing the tests 😄)

This ties into yonaskolb/XcodeGen#284

Short description 📝

Updates output to match what Xcode 9.3 would have produced.

Solution 📦

Changed the ordering of codeCoverageEnabled & shouldUseLaunchSchemeArgsEnv. Only wrote language if actually had a value.

Implementation 👩‍💻👨‍💻

• Changed the ordering of codeCoverageEnabled & shouldUseLaunchSchemeArgsEnv.
• Modified TestAction and LaunchAction to only print language if set.

GIF

---

This change is 

[welcome]

Thanks for opening this pull request! Please check out our contributing guidelines.

[tuistbot]

	1 Error
🚫	Please include a CHANGELOG entry. You can find the guidelines at CHANGELOG_GUIDELINES.md.

Generated by 🚫 Danger

[pepicrft]

Good job @LinusU. You'd need to update the CHANGELOG to include your changes in the next version. Regarding the tests failing it seems that there's something wrong with the Danger script. It's a bit weird because it's not related to your changes.

My guess here is that danger-ruby-swiftlint version has been bumped and it's causing that bug that you see in the logs. Could you try pinning that dependency to the version 0.11.1?

# Gemfile
pod "danger-swiftlint", "0.11.1"

If that doesn't work we can disable swiftlint from Danger and open an issue to fix it on another PR. This PR should be blocked by this 😛

[LinusU]

You'd need to update the CHANGELOG to include your changes in the next version.

Will do!

Regarding the tests failing [...]

The tests fail locally for me since part of the tests is cloning other repositories, opening, and then saving back the XcodeProj. Since these projects are still using Xcode 9.2, saving them will reorder the mentioned attributes, and remove the language property if it's empty. Therefore the tests "fail".

Potentially these projects would soon be updated, I could potentially go and submit a PR to each of them 😄

[pepicrft]

Can't we make this change in a way it's backward compatible with those projects that haven't been updated yet? @LinusU

[pepicrft]

@LinusU are you ok if I merge this one? I'll solve the issues on master and release a new version of the library.

[LinusU]

Yes please! Sorry for the late response, currently on vacation 🏝🍹

[welcome]

Congrats on merging your first pull request! We here at xcode.swift are proud of you! Join our slack channel to talk to other contributors.

[yonaskolb]

Thanks @LinusU! Enjoy the vacation! 😄 🏝🍹

[pepicrft]

Drink some Mojitos for us 🍹!