Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Danger to warn if the PR title contains WIP #259

Merged
merged 4 commits into from
Apr 30, 2018
+4 −0
Merged

Update Danger to warn if the PR title contains WIP #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34cde39
Update Danger to warn if the PR title contains WIP
Apr 30, 2018
8945b30
Update CHANGELOG
Apr 30, 2018
0726268
Merge branch 'master' into danger-checks
Apr 30, 2018
7217ddf
Merge branch 'master' into danger-checks
Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- `fullPath(fileElement:reference:sourceRoot:)` now returns the correct path for files that exist within a variant group https://github.com/xcodeswift/xcproj/pull/255 by @ileitch

### Added
- Update Danger to warn if the PR title contains WIP https://github.com/xcodeswift/xcproj/pull/259 by @pepibumur.
- Test coverage reports https://github.com/xcodeswift/xcproj/pull/258 by @pepibumur

## 4.3.0
Expand Down
3 changes: 3 additions & 0 deletions Dangerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@ danger.import_dangerfile(gem: 'danger-xcodeswift')
# Carthage
Danger::Plugins::Carthage.new(self).execute

# WIP
warn "PR is classed as Work in Progress" if github.pr_title.include? "[WIP]"

# Swiftlint
swiftlint.lint_files