Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #297

Merged
merged 6 commits into from
Sep 11, 2018
Merged

Some fixes #297

merged 6 commits into from
Sep 11, 2018

Conversation

pepicrft
Copy link
Contributor

Description 📝

  • Change PBXBuildFile.file attribute to be of type PBXFileElement.
  • Add PBXBuildPhase.add(file:) method that takes a file element and returns a build file.
  • Add PBXProj.rootObject attribute.
  • Fix XCBuildConfiguration.baseConfiguration type.

@pepicrft pepicrft self-assigned this Sep 11, 2018
@ghost
Copy link

ghost commented Sep 11, 2018

Danger run resulted in 2 messages; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #297 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   74.13%   73.87%   -0.26%     
==========================================
  Files         116      116              
  Lines        5447     5466      +19     
==========================================
  Hits         4038     4038              
- Misses       1409     1428      +19
Impacted Files Coverage Δ
...es/xcodeproj/Objects/BuildPhase/PBXBuildFile.swift 80.64% <ø> (ø) ⬆️
...j/Objects/Configuration/XCBuildConfiguration.swift 62.85% <ø> (ø) ⬆️
Sources/xcodeproj/Objects/Project/PBXProj.swift 72.22% <0%> (-18.48%) ⬇️
...s/xcodeproj/Objects/BuildPhase/PBXBuildPhase.swift 34.4% <0%> (-3.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b4769...60096f0. Read the comment docs.

@pepicrft pepicrft merged commit 99c0913 into master Sep 11, 2018
@pepicrft pepicrft deleted the fixes branch September 11, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant