Add Swiftformat #375
Add Swiftformat #375
Conversation
|
Not sure I understand the reason for removing SwiftLint? SwiftFormat is great, and that's a good addition, but auto-formatting doesn't replaces the value of linting. It would just replace something like |
That's a good point. The Dangerfile has swiftformat set up to run as a linter, but I guess since it's not its primary goal, it doesn't provide the same level of linter that Swiftlint does. Let me check if I can configure both without conflicting with each other. |
|
Added Swiftlint back and fixed all the warnings and errors that we had in the project. Let mek now what you think @yonaskolb |
| @@ -4,9 +4,6 @@ require 'fileutils' | |||
| require 'colorize' | |||
|
|
|||
| task :release_check do | |||
| puts "Linting code".colorize(:cyan) | |||
| system("swiftlint") || abort | |||
There was a problem hiding this comment.
Do we want to keep this?
There was a problem hiding this comment.
I think it's fine to get rid of it since we are running the linter on the PRs before they get merged.
Short description 📝
Add swiftformat and set up Danger to run it in a strict manner so that warnings are reported as errors.