Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift 5 #397

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Add support for Swift 5 #397

merged 3 commits into from
Apr 2, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Apr 2, 2019

Short description πŸ“

Adds support for Swift 5

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Update .swift-version
  • Replace SwiftShell with Shell
  • Add swift_version to .podspec.

@pepicrft pepicrft self-assigned this Apr 2, 2019
@pepicrft pepicrft requested review from yonaskolb, wolffan and a team April 2, 2019 07:35
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #397 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   78.06%   78.06%   +<.01%     
==========================================
  Files         140      140              
  Lines        5994     5996       +2     
==========================================
+ Hits         4679     4681       +2     
  Misses       1315     1315
Impacted Files Coverage Ξ”
...s/xcodeprojTests/Objects/Files/PBXGroupTests.swift 88.67% <100%> (-0.42%) ⬇️
...ests/Objects/Project/PBXProjIntegrationTests.swift 100% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 065f348...2cebeb1. Read the comment docs.

@pepicrft pepicrft merged commit 84c91c1 into master Apr 2, 2019
@pepicrft pepicrft deleted the swift-5 branch April 2, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant