Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to XcodeProj #398

Merged
merged 6 commits into from
Apr 2, 2019
Merged

Rename package to XcodeProj #398

merged 6 commits into from
Apr 2, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Apr 2, 2019

Resolves #393

Short description 📝

As @Dschee suggested here, a camelcased name would be more aligned with the convention most projects embrace.

This PR renames the module from xcodeproj to XcodeProj. Note that the repository and pod name will remain the same, xcodeproj.

@pepicrft pepicrft self-assigned this Apr 2, 2019
@pepicrft pepicrft mentioned this pull request Apr 2, 2019
6 tasks
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files         140      140           
  Lines        5996     5996           
=======================================
  Hits         4681     4681           
  Misses       1315     1315
Impacted Files Coverage Δ
...codeprojTests/Workspace/XCWorkspaceDataTests.swift 89.33% <ø> (ø) ⬆️
...codeprojTests/Objects/Project/PBXProj+XCTest.swift 0% <ø> (ø) ⬆️
...Objects/BuildPhase/PBXSourcesBuildPhaseTests.swift 100% <ø> (ø) ⬆️
...codeprojTests/Project/WorkspaceSettingsTests.swift 100% <ø> (ø) ⬆️
...rojTests/Objects/Targets/PBXProductTypeTests.swift 100% <ø> (ø) ⬆️
...jTests/Workspace/XCWorkspaceDataElementTests.swift 100% <ø> (ø) ⬆️
...rojTests/Objects/Files/PBXFileReferenceTests.swift 83.33% <ø> (ø) ⬆️
...odeprojTests/Objects/Files/PBXGroup+Fixtures.swift 100% <ø> (ø) ⬆️
...s/Configuration/XCConfigurationList+Fixtures.swift 100% <ø> (ø) ⬆️
...ts/xcodeprojTests/Utils/CommentedStringTests.swift 98.11% <ø> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c91c1...1b5fc42. Read the comment docs.

@pepicrft pepicrft merged commit 86b5dd4 into master Apr 2, 2019
@dflems dflems mentioned this pull request Oct 26, 2020
@danieleformichelli danieleformichelli deleted the rename-module branch February 18, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant