Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RemoteRunnable #400

Merged
merged 3 commits into from
May 24, 2019
Merged

Add support for RemoteRunnable #400

merged 3 commits into from
May 24, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Apr 2, 2019

Resolves #276

Short description πŸ“

As @brentleyjones pointed out, extensions use a type of runnable that is not supported by xcodeproj, RemoteRunnable. This PR adds support for it.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Add Runnable class that both RemoteRunnable and BuildableProductRunnable inherit from.
  • Update LaunchAction to parse the runnable into the right type.
  • Add tests.

@pepicrft pepicrft self-assigned this Apr 2, 2019
@joncardasis
Copy link

Any movement on this getting merged? This also addresses Apple Watch schemes.

@pepicrft pepicrft changed the title [WIP] Add support for RemoteRunnable Add support for RemoteRunnable May 24, 2019
@pepicrft pepicrft force-pushed the remote-runable-support branch from 0955fc0 to 8b15bbb Compare May 24, 2019 14:50
@pepicrft pepicrft mentioned this pull request May 24, 2019
6 tasks
@pepicrft pepicrft merged commit aa77dea into master May 24, 2019
@pepicrft pepicrft deleted the remote-runable-support branch May 24, 2019 15:37
@pepicrft
Copy link
Contributor Author

Any movement on this getting merged? This also addresses Apple Watch schemes.

@joncardasis you can point your project to master and you should be able to define remote runnables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support RemoteRunnable in Schemes
2 participants