Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 Fixes #402

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Swift 5 Fixes #402

merged 3 commits into from
Apr 5, 2019

Conversation

samisuteria
Copy link
Contributor

Short description πŸ“

Tests were not passing on CircleCI because project was not set up for Swift 5.

Solution πŸ“¦

Update Package.swift for Swift 5 and update tests.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Update Package.swift for Swift 5.
  • Update Tests

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b02ff3). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #402   +/-   ##
========================================
  Coverage          ?   78.1%           
========================================
  Files             ?     140           
  Lines             ?    6005           
  Branches          ?       0           
========================================
  Hits              ?    4690           
  Misses            ?    1315           
  Partials          ?       0
Impacted Files Coverage Ξ”
...deprojTests/Extensions/XCTestCase+Assertions.swift 23.07% <0%> (ΓΈ)
...s/xcodeprojTests/Objects/Files/PBXGroupTests.swift 88.67% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6b02ff3...c92be41. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b02ff3). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #402   +/-   ##
========================================
  Coverage          ?   78.1%           
========================================
  Files             ?     140           
  Lines             ?    6005           
  Branches          ?       0           
========================================
  Hits              ?    4690           
  Misses            ?    1315           
  Partials          ?       0
Impacted Files Coverage Ξ”
...deprojTests/Extensions/XCTestCase+Assertions.swift 23.07% <0%> (ΓΈ)
...s/xcodeprojTests/Objects/Files/PBXGroupTests.swift 88.67% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6b02ff3...c92be41. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b02ff3). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #402   +/-   ##
========================================
  Coverage          ?   78.1%           
========================================
  Files             ?     140           
  Lines             ?    6005           
  Branches          ?       0           
========================================
  Hits              ?    4690           
  Misses            ?    1315           
  Partials          ?       0
Impacted Files Coverage Ξ”
...deprojTests/Extensions/XCTestCase+Assertions.swift 23.07% <0%> (ΓΈ)
...s/xcodeprojTests/Objects/Files/PBXGroupTests.swift 88.67% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6b02ff3...79d948c. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b02ff3). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #402   +/-   ##
========================================
  Coverage          ?   78.1%           
========================================
  Files             ?     140           
  Lines             ?    6005           
  Branches          ?       0           
========================================
  Hits              ?    4690           
  Misses            ?    1315           
  Partials          ?       0
Impacted Files Coverage Ξ”
...deprojTests/Extensions/XCTestCase+Assertions.swift 23.07% <0%> (ΓΈ)
...s/xcodeprojTests/Objects/Files/PBXGroupTests.swift 88.67% <100%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6b02ff3...c92be41. Read the comment docs.

@pepicrft pepicrft merged commit 4692ec6 into tuist:master Apr 5, 2019
@samisuteria samisuteria deleted the swift-5-fixes branch April 5, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants