-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 5 Fixes #402
Swift 5 Fixes #402
Conversation
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage ? 78.1%
========================================
Files ? 140
Lines ? 6005
Branches ? 0
========================================
Hits ? 4690
Misses ? 1315
Partials ? 0
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage ? 78.1%
========================================
Files ? 140
Lines ? 6005
Branches ? 0
========================================
Hits ? 4690
Misses ? 1315
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage ? 78.1%
========================================
Files ? 140
Lines ? 6005
Branches ? 0
========================================
Hits ? 4690
Misses ? 1315
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
========================================
Coverage ? 78.1%
========================================
Files ? 140
Lines ? 6005
Branches ? 0
========================================
Hits ? 4690
Misses ? 1315
Partials ? 0
Continue to review full report at Codecov.
|
Short description π
Tests were not passing on CircleCI because project was not set up for Swift 5.
Solution π¦
Update Package.swift for Swift 5 and update tests.
Implementation π©βπ»π¨βπ»