Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some variables to have a more representative name #415

Merged
merged 6 commits into from
May 3, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented May 2, 2019

Resolves #411

Short description 📝

As @gubikmic pointed out here, unsync is quite a vague and ambiguous prefix that makes it hard to understand what certain variables are for.

Solution 📦

Since variables prefixed by unsync- are not-thread-safe variables, I change the prefix to notThreadSafe- instead.

@pepicrft pepicrft requested a review from a team May 2, 2019 17:56
@pepicrft pepicrft self-assigned this May 2, 2019
@yonaskolb
Copy link
Collaborator

How about just _projects?

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #415 into master will decrease coverage by 0.01%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   78.83%   78.82%   -0.02%     
==========================================
  Files         140      140              
  Lines        6772     6771       -1     
==========================================
- Hits         5339     5337       -2     
- Misses       1433     1434       +1
Impacted Files Coverage Δ
Sources/xcodeproj/Objects/Project/PBXObjects.swift 74.03% <68.18%> (ø) ⬆️
Sources/xcodeproj/Objects/Files/PBXGroup.swift 80.23% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15705b6...8eea8a5. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is 78.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files         140      140           
  Lines        6772     6772           
=======================================
  Hits         5339     5339           
  Misses       1433     1433
Impacted Files Coverage Δ
Sources/xcodeproj/Objects/Targets/PBXTarget.swift 74.76% <100%> (ø) ⬆️
...codeprojTests/Objects/Targets/PBXTargetTests.swift 100% <100%> (ø) ⬆️
Sources/xcodeproj/Objects/Project/PBXObjects.swift 74.03% <68.18%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15705b6...f629839. Read the comment docs.

@pepicrft pepicrft merged commit 50cd5c1 into master May 3, 2019
@pepicrft pepicrft deleted the rename-unsync branch May 3, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsync........?
2 participants