-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PBXContainerItemProxy.remoteGlobalID #445
Conversation
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 80.37% 80.38% +<.01%
==========================================
Files 149 149
Lines 7635 7668 +33
==========================================
+ Hits 6137 6164 +27
- Misses 1498 1504 +6
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 80.37% 80.38% +<.01%
==========================================
Files 149 149
Lines 7635 7668 +33
==========================================
+ Hits 6137 6164 +27
- Misses 1498 1504 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 80.37% 80.38% +<.01%
==========================================
Files 149 149
Lines 7635 7668 +33
==========================================
+ Hits 6137 6164 +27
- Misses 1498 1504 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @yonaskolb. Would you mind adding an entry to the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yonaskolb good catch!
I updated the CHANGELOG here |
Short description 📝
#425 changed
PBXContainerItemProxy.remoteGlobalID
into a string to support references outside of the project. This created a problem because if setting the id from a PBXObject.uuid, this would changed upon reference resolution. Outsider users of xcodeproj also don't have access to the PBXReferenceSolution 📦
Create an enum that allows for setting an
.object
as before or a.string
for remote projects