Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PBXContainerItemProxy.remoteGlobalID #445

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix PBXContainerItemProxy.remoteGlobalID #445

merged 1 commit into from
Jun 10, 2019

Conversation

yonaskolb
Copy link
Collaborator

Short description 📝

#425 changed PBXContainerItemProxy.remoteGlobalID into a string to support references outside of the project. This created a problem because if setting the id from a PBXObject.uuid, this would changed upon reference resolution. Outsider users of xcodeproj also don't have access to the PBXReference

Solution 📦

Create an enum that allows for setting an .object as before or a .string for remote projects

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #445 into master will increase coverage by <.01%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   80.37%   80.38%   +<.01%     
==========================================
  Files         149      149              
  Lines        7635     7668      +33     
==========================================
+ Hits         6137     6164      +27     
- Misses       1498     1504       +6
Impacted Files Coverage Δ
...codeproj/Objects/Sourcery/Equality.generated.swift 93.93% <100%> (ø) ⬆️
...sts/Objects/Files/PBXContainerItemProxyTests.swift 100% <100%> (ø) ⬆️
Sources/xcodeproj/Utils/ReferenceGenerator.swift 86.43% <100%> (ø) ⬆️
...ojTests/Objects/Targets/PBXNativeTargetTests.swift 100% <100%> (ø) ⬆️
...es/xcodeproj/Objects/Targets/PBXNativeTarget.swift 92.1% <100%> (ø) ⬆️
...codeproj/Objects/Files/PBXContainerItemProxy.swift 84.88% <80.64%> (-3.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72657d8...2f45b83. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #445 into master will increase coverage by <.01%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   80.37%   80.38%   +<.01%     
==========================================
  Files         149      149              
  Lines        7635     7668      +33     
==========================================
+ Hits         6137     6164      +27     
- Misses       1498     1504       +6
Impacted Files Coverage Δ
...codeproj/Objects/Sourcery/Equality.generated.swift 93.93% <100%> (ø) ⬆️
...sts/Objects/Files/PBXContainerItemProxyTests.swift 100% <100%> (ø) ⬆️
Sources/xcodeproj/Utils/ReferenceGenerator.swift 86.43% <100%> (ø) ⬆️
...ojTests/Objects/Targets/PBXNativeTargetTests.swift 100% <100%> (ø) ⬆️
...es/xcodeproj/Objects/Targets/PBXNativeTarget.swift 92.1% <100%> (ø) ⬆️
...codeproj/Objects/Files/PBXContainerItemProxy.swift 84.88% <80.64%> (-3.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72657d8...2f45b83. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #445 into master will increase coverage by <.01%.
The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   80.37%   80.38%   +<.01%     
==========================================
  Files         149      149              
  Lines        7635     7668      +33     
==========================================
+ Hits         6137     6164      +27     
- Misses       1498     1504       +6
Impacted Files Coverage Δ
...codeproj/Objects/Sourcery/Equality.generated.swift 93.93% <100%> (ø) ⬆️
...sts/Objects/Files/PBXContainerItemProxyTests.swift 100% <100%> (ø) ⬆️
Sources/xcodeproj/Utils/ReferenceGenerator.swift 86.43% <100%> (ø) ⬆️
...ojTests/Objects/Targets/PBXNativeTargetTests.swift 100% <100%> (ø) ⬆️
...es/xcodeproj/Objects/Targets/PBXNativeTarget.swift 92.1% <100%> (ø) ⬆️
...codeproj/Objects/Files/PBXContainerItemProxy.swift 84.88% <80.64%> (-3.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72657d8...2f45b83. Read the comment docs.

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @yonaskolb. Would you mind adding an entry to the changelog?

Copy link
Contributor

@damirdavletov damirdavletov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yonaskolb good catch!

@pepicrft pepicrft merged commit fa30960 into master Jun 10, 2019
@pepicrft pepicrft deleted the fix/remote_id branch June 10, 2019 10:35
@pepicrft
Copy link
Contributor

I updated the CHANGELOG here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants