Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customLaunchCommand attribute to the launch action #451

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Jun 23, 2019

Short description 📝

As described here the new version of Xcode has a new feature that is disabled by default, using a custom command to launch a commandn line tool.

Solution 📦

Add the customLaunchCommand attribute to LaunchAction.

Implementation 👩‍💻👨‍💻

  • Add the custom case to the LaunchAction.Style enum.
  • Add the customLaunchCommand attribute to XCScheme.LaunchAction.
  • Decode and encode the new attribute.
  • Update the == method to include the new attribute.

@pepicrft pepicrft requested a review from a team June 23, 2019 08:36
@pepicrft pepicrft self-assigned this Jun 23, 2019
@pepicrft pepicrft mentioned this pull request Jun 23, 2019
6 tasks
@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #451 into master will decrease coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   80.43%   80.41%   -0.03%     
==========================================
  Files         149      149              
  Lines        7652     7659       +7     
==========================================
+ Hits         6155     6159       +4     
- Misses       1497     1500       +3
Impacted Files Coverage Δ
...urces/xcodeproj/Scheme/XCScheme+LaunchAction.swift 58.03% <44.44%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa14558...d15ab3a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #451 into master will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   80.95%   80.94%   -0.02%     
==========================================
  Files         147      147              
  Lines        7588     7592       +4     
==========================================
+ Hits         6143     6145       +2     
- Misses       1445     1447       +2
Impacted Files Coverage Δ
Tests/xcodeprojTests/Scheme/XCSchemeTests.swift 100% <100%> (ø) ⬆️
...urces/xcodeproj/Scheme/XCScheme+LaunchAction.swift 58.54% <55.55%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be178b...357fbf4. Read the comment docs.

kwridan
kwridan previously approved these changes Jun 23, 2019
Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We could add it to one of the fixtures to ensure it's covered

@pepicrft pepicrft merged commit 8c77525 into master Jun 24, 2019
@pepicrft pepicrft deleted the custom-command branch June 24, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants