Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OSLogs #453

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Remove OSLogs #453

merged 2 commits into from
Jun 24, 2019

Conversation

pepicrft
Copy link
Contributor

Short description 📝

We introduced them to make it easier for users of the library to give us numbers that help optimize the library operations. They don't seem to be used so I'm removing them on this PR.

Solution 📦

Remove all usages and the utility class built to wrap oslog calls.

@pepicrft pepicrft requested review from yonaskolb and a team June 24, 2019 13:40
@pepicrft pepicrft self-assigned this Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #453 into master will increase coverage by 0.52%.
The diff coverage is 78.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   80.43%   80.95%   +0.52%     
==========================================
  Files         149      147       -2     
  Lines        7652     7588      -64     
==========================================
- Hits         6155     6143      -12     
+ Misses       1497     1445      -52
Impacted Files Coverage Δ
Sources/xcodeproj/Project/XcodeProj.swift 45.74% <76%> (+1.3%) ⬆️
...xcodeproj/Objects/Project/PBXObjectReference.swift 92.59% <85.71%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914cb42...8ab538d. Read the comment docs.

@pepicrft pepicrft merged commit 9be178b into master Jun 24, 2019
@pepicrft pepicrft deleted the remove-oslogs branch June 24, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant