Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PBXTargetDependency.productReference #481

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

yonaskolb
Copy link
Collaborator

This adds support for Target Dependencies that are Swift Package Products. This is so that Xcode knows that a certain package has to be built first.
Helps resolve yonaskolb/XcodeGen#624

@yonaskolb
Copy link
Collaborator Author

@pepibumur would you be able to look into why CI is failing?

pepicrft
pepicrft previously approved these changes Sep 27, 2019
@pepicrft
Copy link
Contributor

@pepibumur would you be able to look into why CI is failing?

Sure, I'll look into it.

@yonaskolb yonaskolb merged commit 1c4fc0f into master Sep 27, 2019
@yonaskolb yonaskolb deleted the fix/package_target_dependencies branch September 27, 2019 09:31
@pepicrft
Copy link
Contributor

😅 I was pushing a commit with the fix for CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants