Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Products group serialisation with temporary ids #489

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

damirdavletov
Copy link
Contributor

Short description 📝

When adding remote xcodeproj bundle reference to the project, remote product references are serialised with temporary ids.

Solution 📦

Fix serialisation of Products group of the remote project references

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #489 into master will increase coverage by 0.39%.
The diff coverage is 98.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   82.46%   82.85%   +0.39%     
==========================================
  Files         148      149       +1     
  Lines        8073     8149      +76     
==========================================
+ Hits         6657     6752      +95     
+ Misses       1416     1397      -19
Impacted Files Coverage Δ
...XcodeProjTests/Utils/ReferenceGeneratorTests.swift 100% <100%> (ø)
Sources/XcodeProj/Utils/ReferenceGenerator.swift 88.12% <95.45%> (+1.69%) ⬆️
...codeProj/Objects/Files/PBXContainerItemProxy.swift 86.04% <0%> (+1.16%) ⬆️
Sources/XcodeProj/Objects/Project/PBXObjects.swift 75.81% <0%> (+2.52%) ⬆️
Sources/XcodeProj/Objects/Project/PBXProj.swift 71.84% <0%> (+3.88%) ⬆️
.../XcodeProj/Objects/Targets/PBXReferenceProxy.swift 23.07% <0%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e804e...41cc645. Read the comment docs.

@pepicrft pepicrft merged commit 8b0bfdb into tuist:master Oct 11, 2019
@damirdavletov
Copy link
Contributor Author

Thanks @pepibumur !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants