Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test plans support #491

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Conversation

maniramezan
Copy link
Contributor

Resolves #442

Short description 📝

This PR is for adding support for parsing and generating test plans feature added in Xcode 11.

Solution 📦

Since it's very similar to existing Testables structure, but much simpler, I followed the same pattern that already existed for Testables. Test plans structure in scheme file is as follow:

...
<TestAction
    ...>
    <TestPlans>
        <TestPlanReference
            reference = "container:uitests.xctestplan"
            default = "YES">
        </TestPlanReference>
        <TestPlanReference
            reference = "container:unittests.xctestplan">
        </TestPlanReference>
    </TestPlans>
    ...
  </TestAction>
  ...

Implementation 👩‍💻👨‍💻

It was pretty straightforward with following the steps for Testables and the adding tests for XML parser. Then added the test plan support to iOS scheme that's used for scheme testing and fixed failing tests.

pepicrft
pepicrft previously approved these changes Oct 27, 2019
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good @maniramezan. Would you mind updating the CHANGELOG file to mention this improvement? After that we are good to merge 🎉

@maniramezan
Copy link
Contributor Author

Awesome : ) Added the changes to CHANGELOG file. Let me know if it needed more explanation or links to what test plans.

@pepicrft pepicrft merged commit 850d0c3 into tuist:master Oct 27, 2019
@maniramezan maniramezan deleted the feature/test_plans branch October 28, 2019 06:04
@pepicrft pepicrft mentioned this pull request Nov 7, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Xcode 11 changes
2 participants