Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equality checking of dictionaries #667

Merged

Conversation

brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Feb 23, 2022

Short description 📝

Dictionary equality checks were only wrapping the lefthand side in NSDictionary, which was causing equality to return false unnecessarily.

Solution 📦

Now the righthand side is wrapped in an NSDictionary as well.

Implementation 👩‍💻👨‍💻

  • Updated Equality.stencil
  • Updated Equality.generated.swift

@hisaac hisaac requested review from a team, RomainBoulay and andreacipriani and removed request for a team February 23, 2022 16:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #667 (ff0000b) into main (fae1867) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files         157      157           
  Lines        8987     8987           
=======================================
  Hits         7617     7617           
  Misses       1370     1370           
Impacted Files Coverage Δ
...codeProj/Objects/Sourcery/Equality.generated.swift 96.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5b3d7...ff0000b. Read the comment docs.

@fortmarek fortmarek merged commit b030c96 into tuist:main Feb 28, 2022
@brentleyjones brentleyjones deleted the bj/fix-equality-checking-of-dictionaries branch February 28, 2022 20:05
@luispadron
Copy link
Collaborator

@all-contributors add @brentleyjones for code

@allcontributors
Copy link
Contributor

@luispadron

I've put up a pull request to add @brentleyjones! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants