Print errors that arise when parsing the manifest

[pepicrft]

Fixes #1120

Short description 📝

This PR fixes the issue reported by @kwridan here. I changed the logic in the ManifestLoader class to use the new observable APIs and print all the events that are sent through the standard error.

Moreover, I changed the way tuistenv passes the environment variable by setting it to the environment dictionary instead (look at the CommandRunner.swift) class.

[pepicrft]

@kwridan while debugging this issue I noticed that when tuistenv is run from Xcode or using swift run tuistenv, it reads the binary from the global ~/.tuist/directory, instead of the one under .build/debug. I'll open a follow-up PR changing that behavior.

[codecov]

Codecov Report

Merging #1125 into master will increase coverage by 0.13%.
The diff coverage is 68.57%.

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   77.11%   77.24%   +0.13%     
==========================================
  Files         270      269       -1     
  Lines        9429     9484      +55     
==========================================
+ Hits         7271     7326      +55     
  Misses       2158     2158              

Impacted Files	Coverage Δ
Sources/ProjectDescription/Up/UpCarthage.swift	0.00% <0.00%> (ø)
Sources/ProjectDescription/Up/UpCustom.swift	0.00% <0.00%> (ø)
Sources/ProjectDescription/Up/UpHomebrew.swift	0.00% <0.00%> (ø)
Sources/ProjectDescription/Up/UpHomebrewTap.swift	0.00% <0.00%> (ø)
Sources/TuistCore/Models/Config.swift	60.00% <ø> (ø)
...TuistGenerator/Generator/BuildPhaseGenerator.swift	97.74% <ø> (ø)
...ces/TuistGenerator/Generator/ConfigGenerator.swift	94.44% <ø> (-3.48%)	⬇️
Sources/TuistGenerator/Generator/Generator.swift	0.00% <0.00%> (ø)
...s/TuistKit/ProjectGenerator/ProjectGenerator.swift	16.90% <0.00%> (ø)
...rces/TuistScaffold/TemplatesDirectoryLocator.swift	27.27% <0.00%> (ø)
... and 56 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce75b4f...e60091d. Read the comment docs.

[kwridan]

thanks for looking into this @pepibumur

[ollieatkinson]

I ran this locally and it appears the issue @kwridan found is still present:

~/Development/Tuist/fixtures/ios_app_with_tests [print-errors !?] $ swift run tuist generate
/Users/oliver/Development/Tuist/fixtures/ios_app_with_tests/Project.swift:14:91: error: expected ',' separator
                                                           "CODE_SIGNING_REQUIRED": "NO"])),
                       
Unexpected output trying to parse the manifest at path /Users/oliver/Development/Tuist/fixtures/ios_app_with_tests/Project.swift

~/Development/Tuist/fixtures/ios_app_with_tests [print-errors !?] $ swift run tuist generate
/Users/oliver/Development/Tuist/fixtures/ios_app_with_tests/Project.swift:14
Unexpected output trying to parse the manifest at path /Users/oliver/Development/Tuist/fixtures/ios_app_with_tests/Project.swift

Notice the second run has trimmed the error

[pepicrft]

@ollieatkinson would you mind trying again with the latest commits? I can't reproduce the issue anymore.

[ollieatkinson]

I was able to run this several times and the output was consistent 👍

[pepicrft]

I added an acceptance test to detect regressions here.