Update XcodeProj to 8.8.0 #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -283,7 +283,7 @@ final class DefaultSettingsProvider_iOSTests: TuistUnitTestCase { | |||
| // Then | |||
|
|
|||
| XCTAssertSettings(got, containsAll: projectEssentialDebugSettings) | |||
| XCTAssertEqual(got.count, 49) | |||
| XCTAssertEqual(got.count, 50) | |||
There was a problem hiding this comment.
@kwridan I guess the change here is for some change in XcodeProj, is it correct?
There was a problem hiding this comment.
Yes it's a consequence of tuist/XcodeProj#706 - adding DEAD_CODE_STRIPPING as a new recommended setting.
danieleformichelli
changed the title
kwridan
approved these changes
Jul 25, 2022
| @@ -283,7 +283,7 @@ final class DefaultSettingsProvider_iOSTests: TuistUnitTestCase { | |||
| // Then | |||
|
|
|||
| XCTAssertSettings(got, containsAll: projectEssentialDebugSettings) | |||
| XCTAssertEqual(got.count, 49) | |||
| XCTAssertEqual(got.count, 50) | |||
There was a problem hiding this comment.
Yes it's a consequence of tuist/XcodeProj#706 - adding DEAD_CODE_STRIPPING as a new recommended setting.
danieleformichelli
added
the
changelog:changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/tuist/tuist/issues/YYY
Request for comments document (if applies):
Short description 📝
How to test the changes locally 🧐
Checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, whenever it should be included in the “Added”, “Fixed” or “Changed” section of the CHANGELOG. Note: when included in the CHANGELOG, the title of the PR will be used as entry, please make sure it is clear and suitable.TuistGraph.Target, theConstants.cacheVersionhas been updated.