Skip to content

Commit

Permalink
Fix group by test
Browse files Browse the repository at this point in the history
This test is ordered by users.id, but it is not an aggregrated column, which is not compatible with the new only_full_group_by mode introduced into mysql 5.7.5.

Relates to LiveRamp#204
  • Loading branch information
tuliren committed Dec 12, 2017
1 parent 31ebaf7 commit a1e9c0f
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import java.io.IOException;
import java.sql.Timestamp;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import java.util.function.Consumer;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -691,7 +690,7 @@ public void testDistinctQuery() throws Exception {
.select(User.HANDLE, User.BIO)
.groupBy(User.HANDLE, User.BIO)
.orderBy(User.HANDLE)
.orderBy(User.ID)
.orderBy(AggregatedColumn.MAX(User.ID))
.fetch();
assertEquals(3, results1.size());
assertEquals(Lists.newArrayList("A", "A", "C"), results1.gets(User.HANDLE));
Expand Down

0 comments on commit a1e9c0f

Please sign in to comment.