Merge pull request agola-io#253 from camandel/remove_waitapprove_if_s…

…topped Remove WaitingApproval for stopped tasks
tulliobotti64 · Feb 8, 2021 · 204a680 · 204a680
2 parents ded2f33 + 51ab1f1
commit 204a680
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/internal/services/runservice/action/action.go b/internal/services/runservice/action/action.go
@@ -127,6 +127,9 @@ func (h *ActionHandler) StopRun(ctx context.Context, req *RunStopRequest) error
 		return errors.Errorf("run %s is not running but in %q phase", r.ID, r.Phase)
 	}
 	r.Stop = true
+	for _, t := range r.TasksWaitingApproval() {
+		r.Tasks[t].WaitingApproval = false
+	}
 
 	_, err = store.AtomicPutRun(ctx, h.e, r, nil, cgt)
 	return err