Add support for pixelwise width and height in posframe-show #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaasonSun
force-pushed
the
feature/pixelwise-size
branch
from
e53f205 to
7090044
Compare
|
I think posframe will not support pixelwise size, for fit-frame-to-buffer do not support pixelwise size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pixel-width and pixel-height option in posframe-show to specify whether width/height is in pixel or char. For compatibility, pixel-width/height works only when width/height is set and will ignore min/max-width/height.
This is a quick hack, not sure if this is the best way to add pixelwise size control to posframe.