-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tui competition #37
Merged
Merged
Tui competition #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es when I was playing around the code :).
…go file move the helping function to little_helpers.go. Also cleaned up the code a little bit and did some changes in the styles.
… on window resize.
…truct fields fix, prepping for adblock
…bountaries too. Also moved the funtion to get the vpn logs in the little_helpers.go so the switch statement doesn't look like shit and I added a check so I won't have to update m.logs slice everytime if there are NO new logs.
…ork later from my laptop :P .
…es when I was playing around the code :).
…go file move the helping function to little_helpers.go. Also cleaned up the code a little bit and did some changes in the styles.
… on window resize.
…bountaries too. Also moved the funtion to get the vpn logs in the little_helpers.go so the switch statement doesn't look like shit and I added a check so I won't have to update m.logs slice everytime if there are NO new logs.
…ork later from my laptop :P .
…vpn-desktop into tui-competition
…ruct so I can unfold an use the response from the login request in little_helpers.go and also added some example code for log in and log out in StartTUI() in the tui.go .
…ame of the currently connected VPN server panics with runtime error: invalid memory address or nil pointer dereference. So I temporarly disabled it so the VPN status line will just say connected if when you connect.
…o be becaused it is used elsewhere too. Moved the PAFR request construction in the StartUI() function just before the core.GetRoutersAndAccessPoints(&PAFR), it makes more sense to me there.
…ed and change the Disconnect shortcut to shift+d
… tab, changed the status line to be more consistant.
…imensions of the tui and also did some changes to accommodate the help menu. Lastly I added the keybinds, they are only implemented for now to be shown on the help menu but on the next commit I'll replace the hardcoded strings with the keybinds so they can be modified easier in the future.
…y them and cleaner. Also will more easy to implement user key re-binding in the future if we want.
…DMbpsString/UMbpsString get set. Also fixed the style of the help menu.
…d they are initialized in detailedStatsInit() and updated in detailedStatsUpdate(). Also changed changed on how the logs are updated and the viewport width to try and stop it from breaking in certain dimensions, seems to work so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TUI implementation using bubbletea and bubbles.
All basic functions of the VPN client are there.
Settings are yet to implemented and there are some scaling issues to resolve.
😅