Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tag のクリッカブルをデフォルトでやめる #293

Merged
merged 8 commits into from
Feb 10, 2023
Merged

feat: tag のクリッカブルをデフォルトでやめる #293

merged 8 commits into from
Feb 10, 2023

Conversation

Hidetaro7
Copy link
Contributor

No description provided.

@Hidetaro7 Hidetaro7 requested a review from knokmki612 October 13, 2022 14:04
@Hidetaro7 Hidetaro7 self-assigned this Oct 13, 2022
@Hidetaro7 Hidetaro7 linked an issue Oct 13, 2022 that may be closed by this pull request
Tag / FilledTag はデフォルトではクリッカブルでなくていいのでは #280
Closed
knokmki612
knokmki612 reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@knokmki612 knokmki612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#289 #292 との変更の重複がみられるのでコミットとその差分を整理してもらいたいです

@Hidetaro7 Hidetaro7 requested a review from knokmki612 December 8, 2022 12:16
@knokmki612
Copy link
Member

knokmki612 commented Jan 10, 2023 •
edited
Loading

TODO

  • 重複差分の解消

@knokmki612 knokmki612 assigned knokmki612 and unassigned Hidetaro7 and knokmki612 Jan 10, 2023
@knokmki612
Copy link
Member

重複については 0a6c796 で解消済みの様子なので作業不要

@knokmki612 knokmki612 mentioned this pull request Feb 9, 2023
Merged
@knokmki612
feat(Tag): drop aria-pressed (#344)
f859018 
* feat(Tag): drop aria-pressed

* bot: format

---------

Co-authored-by: knokmki612 <[email protected]>
knokmki612
knokmki612 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@knokmki612 knokmki612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

クリッカブルにした場合のバリアントが必要になった気がするのですが、ひとまず別途対応でも良いかと思いましたのでおまかせします。

@Hidetaro7 Hidetaro7 merged commit b9e4120 into develop Feb 10, 2023
@Hidetaro7 Hidetaro7 deleted the feat-tag branch February 10, 2023 12:35
@knokmki612 knokmki612 mentioned this pull request Feb 10, 2023
Closed
@knokmki612 knokmki612 added the breaking-change This change doesn't have backward compatibility label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knokmki612 knokmki612 knokmki612 approved these changes

Assignees
No one assigned
Labels
breaking-change This change doesn't have backward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag / FilledTag はデフォルトではクリッカブルでなくていいのでは
2 participants
@Hidetaro7 @knokmki612