Group and policy builders #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwangvmt
reviewed
Dec 19, 2018
pkg/builder/group/group_builder.go
Outdated
| } | ||
|
|
||
| if groupBuilder.ec.Count() > 0 { | ||
| fmt.Printf("Error : %s\n", groupBuilder.ec.Error()) |
There was a problem hiding this comment.
Better to also log the group id.
pkg/builder/group/group_builder.go
Outdated
| DYNAMIC_GROUP GroupType = "Dynamic" | ||
| ) | ||
| // | ||
| //type GroupBuilder interface { |
There was a problem hiding this comment.
There are lots of commented code in this PR. Please remove it if unnecessary.
pkg/builder/group/policy_builder.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("[AbstractConstraintGroupBuilder] Error building group") | ||
| } | ||
| if groupDTO == nil { |
There was a problem hiding this comment.
Do we need this check? Seems it will not be nil if err == nil.
enlinxu
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add builder support for creating group and policy DTOs.
Updated protobuf bindings using the *.proto files from the 6.3 branch.