-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OM-43683 Add the new Commodity VCPURequest and VMemRequest into SDK #62
Conversation
The change seems much bigger than just adding the two commodities. Are we sure we are creating the diff based on the same branch? |
Let me be more clear and specific. This change contains three parts:
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The followings are changed:
golang.org/x/net
pkg as it is not usedjackfan.us.kg/golang/protobuf
pkg to v1.3.1, otherwiseNonMarketEntityDTO.pb.go
file generation will fail because the reserved value (introduced in Feb 2019) is not recognized