Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder of MergedEntityMetadata, add documentation, and refactor #69

Merged
merged 4 commits into from
Jun 18, 2019

Conversation

ading1977
Copy link
Collaborator

@ading1977 ading1977 commented Jun 11, 2019

This pull request introduces the following changes:

  • Update go protocol to reflect recent changes in SupplyChain.proto. The SupplyChain.proto was recently updated to add a commodities_sold_metadata with the type CommoditySoldMeta. The CommoditySoldMeta type defines a list of fields to patch for a specific commodity which is needed because not all fields in a commodity should be patched during stitching. Compared to this, the original commoditiesSold only allows settings of commodity types, and the stitching process will patch all available fields in a commodity sold.
  • Add builder for CommoditySoldMeta in MergedEntityMetadata.
  • Deprecate the original commoditiesSold field and the corresponding PatchSold and PatchSoldList functions.
  • Add proper documentations to all exported functions.
  • Refactor code.

@coveralls
Copy link

coveralls commented Jun 11, 2019

Coverage Status

Coverage decreased (-2.06%) to 63.628% when pulling c49de35 on ading1977:OM-46988 into 572d0ca on turbonomic:master.

Copy link
Contributor

@pallavidn pallavidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this, then commit.
Default behavior of the keepStandAlone field should be false. Which means after merging the proxy entity will be removed. Probes all explicitly specify if they want the proxy entities to stay after merging.

@ading1977 ading1977 merged commit e8ebccf into turbonomic:master Jun 18, 2019
@ading1977 ading1977 deleted the OM-46988 branch June 18, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants