New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting display name for group policies #75

Merged

ading1977 merged 3 commits into turbonomic:6.4.3 from ading1977:set-displayname

Sep 19, 2019

Collaborator

ading1977 commented Sep 19, 2019

This pull request:

Allow setting display name for group policies
Check if seller entity type is set for buyer groups
Add OnSellerType method for PlaceTogether policy


          Allow setting display name for group policies

db4f590

ading1977 requested review from enlinxu, chlam4 and pallavidn

September 19, 2019 16:39


          Fix test cases

309ecf6

pallavidn reviewed

View reviewed changes

pkg/builder/group/policy_builder.go Outdated Show resolved Hide resolved

pallavidn reviewed

View reviewed changes

pkg/builder/group/policy_builder.go Outdated Show resolved Hide resolved

pallavidn reviewed

View reviewed changes

pkg/builder/group/policy_builder.go Outdated Show resolved Hide resolved

pallavidn reviewed

View reviewed changes

pkg/builder/group/policy_builder.go Outdated Show resolved Hide resolved

pallavidn reviewed

View reviewed changes

pkg/builder/group/policy_builder.go Outdated Show resolved Hide resolved

pallavidn approved these changes

View reviewed changes

Contributor

pallavidn left a comment

Minor fix suggestion - in the inner createXXXPolicyGroup methods, add the display name or policy id to the error string/message.


          Address review comments

7626bbe

coveralls commented Sep 19, 2019

Coverage remained the same at 63.628% when pulling 7626bbe on ading1977:set-displayname into 7ccd23b on turbonomic:6.4.3.

ading1977 merged commit c2695c1 into turbonomic:6.4.3

ading1977 deleted the set-displayname branch

September 19, 2019 20:17

ading1977 added a commit to ading1977/turbo-go-sdk that referenced this pull request


          Merge pull request turbonomic#75 from ading1977/set-displayname

a5f4654

Allow setting display name for group policies

ading1977 added a commit that referenced this pull request


          Merge pull request #75 from ading1977/set-displayname (#76)

15606b6

Allow setting display name for group policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet