Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin update and plugin install should not accept no plugins in args. Closes #199 #204

Merged
merged 4 commits into from
Feb 24, 2021
Merged

plugin update and plugin install should not accept no plugins in args. Closes #199 #204

merged 4 commits into from
Feb 24, 2021

Conversation

binaek
Copy link
Contributor

@binaek binaek commented Feb 19, 2021 •
edited
Loading

Screenshot 2021-02-22 at 10 53 16 PM
Screenshot 2021-02-22 at 10 56 04 PM

@e-gineer @johnsmyth outputs when no plugins are provided.

@binaek binaek added the bug Something isn't working label Feb 19, 2021
@binaek binaek requested a review from kaidaguerre February 19, 2021 15:10
@binaek binaek self-assigned this Feb 19, 2021
@binaek binaek linked an issue Feb 19, 2021 that may be closed by this pull request
plugin update and plugin install should not accept no plugins in args #199
Closed
@binaek binaek requested review from e-gineer and johnsmyth February 23, 2021 09:55
@e-gineer
Copy link
Contributor

e-gineer commented Feb 23, 2021 •
edited
Loading

Comments:

  • Can / should we use the exact output from the help of the command? This seems custom?
  • If custom ... should we include the multi-plugin example? Seems complex / not necessary.
  • If including multiple, I'd remove the spacing so <plugin1> (not <plugin 1>)

@binaek
Copy link
Contributor Author

binaek commented Feb 24, 2021 •
edited
Loading

@e-gineer @johnsmyth here are some updated screenshots. Removed the custom text and have printed out the help text along with an Error: at the top.

steampipe plugin install
Install Output

steampipe plugin update
Update Output

Note: the --config global flag has been removed as a part of a different branch.

@kaidaguerre kaidaguerre merged commit 64074cf into main Feb 24, 2021
@kaidaguerre kaidaguerre deleted the issue-199 branch February 24, 2021 16:00
ahirreddy pushed a commit to ahirreddy/steampipe that referenced this pull request Jul 8, 2024
@sayan133
Update table azure_app_service_web_app to include virtual network con…
c00775d 
…figuration for the app. Closes turbot#193 (turbot#204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidaguerre kaidaguerre Awaiting requested review from kaidaguerre

@e-gineer e-gineer Awaiting requested review from e-gineer

@johnsmyth johnsmyth Awaiting requested review from johnsmyth

Assignees

@binaek binaek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin update and plugin install should not accept no plugins in args
3 participants
@binaek @e-gineer @kaidaguerre