Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaren Garman #1

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Jaren Garman #1

wants to merge 53 commits into from
+504 −8

Conversation

JarenGarman
Copy link

I feel really good about this IC. I didn't find the nested collections in the summary method to be too difficult (definitely needed those helper methods, though) and I learned how to "return" a particular value from an iteration using next (value) (conditional)

@JarenGarman
chore: Add .gitignore for SimpleCov
2dba2bc
@JarenGarman
chore: Add spec_helper
034e48f
@JarenGarman
docs: Format README and fix typo
a978519
@JarenGarman
Merge pull request #1 from JarenGarman/chore/initial_setup
9f4213d 
Chore/initial setup
@JarenGarman
test: Add initial test for Visitor
793304c
@JarenGarman
feat: Add Visitor class with initialize method
4db03bf
@JarenGarman
test: Add tests to round off initialize method
a6dd4a7
@JarenGarman
feat: Add name, height, spending_money, and preferences attributes
c2df8c1
@JarenGarman
test: Add test for add_preference
8b7b34c
@JarenGarman
feat: Add add_preference method
efc6eeb
@JarenGarman
test: Add tests for tall_enough?
c509280
@JarenGarman
test: Fix test for tall_enough?
daeaad1
@JarenGarman
feat: Add tall_enough? method
dcf30fb
@JarenGarman
Merge pull request #2 from JarenGarman/feature/visitors
626c87a 
Feature/visitors
@JarenGarman
test: Add initial test for Ride
27941e4
@JarenGarman
feat: Add Ride with initialize method
9c6c7ca
@JarenGarman
test: Add tests for initialize method
8bdda57
@JarenGarman
feat: Add attributes for name, min_height, admission_fee, excitement,…
fb747be 
… and total_revenue
@JarenGarman
test: Add test for spend_money
a5e0061
@JarenGarman
feat: Add spend_money method
bf0b030
@JarenGarman
test: Fix test for spend_money
0e79f9e
@JarenGarman
test: Add test for empty rider log
c72a4c8
@JarenGarman
feat: Add attribute for rider_log
8f8642e
@JarenGarman
test: Add test for rider_log
91d65b3
@JarenGarman
test: Add tests for board_rider
80b4ab6
@JarenGarman
feat: Add board_rider method
a42191f
@JarenGarman
fix: Add admission_fee to total_revenue instead if 1
ee368fb
@JarenGarman
Merge pull request #3 from JarenGarman/feature/rides
8c2386f 
Feature/rides
@JarenGarman
test: Add initial test for Carnival
1ffdf6d
@JarenGarman
feat: Add Carnival class with initialize method
210026a
@JarenGarman
test: Fix test for board_rider
fa91a38
@JarenGarman
test: Add test for duration
697fabd
@JarenGarman
feat: Add duration attribute
95003de
@JarenGarman
test: Add tests for add_ride and rides
9181c5c
@JarenGarman
feat: Add rides attribute and add_ride method
e693d43
@JarenGarman
test: Add tests for most_popular_ride
6f4df7d
@JarenGarman
test: Fix memoized helpers for rides in carnival_spec
323a77e
@JarenGarman
feat: Add most_popular_ride method
4646cc5
@JarenGarman
test: Add tests for most_profitable_ride
ef2b078
@JarenGarman
feat: Add most_profitable_ride method
aad4787
@JarenGarman
test: Add tests for total_revenue
c8ec032
@JarenGarman
feat: Add total_revenue method
dbed0e0
@JarenGarman
Merge pull request #4 from JarenGarman/feature/carnivals
4e4fb95 
Feature/carnivals
@JarenGarman
test: Add test for summary
22ff0d6
@JarenGarman
feat: Begin summary by creating helper methods for visitors_array and…
499e1a0 
… visitor_hash
@JarenGarman
refactor: Guard against key that does not exist if rider has not ridd…
05b813f 
…en ride
@JarenGarman
feat: Flesh out summary method
9fae960
@JarenGarman
feat: Add rides_array helper method for summary
9e04eac
@JarenGarman
test: Fix test for summary
bb9a435
@JarenGarman
fix: Replace map with each_with_object to get unique visitors
3f48ab2
@JarenGarman
test: Add test for total_revenues class method
13760af
@JarenGarman
test: Fix test for total_revenues
ac50b26
@JarenGarman
feat: Add total_revenues class method
641e6bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JarenGarman