Improve stack traces thrown from client functions #211
+68
−111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stack traces are rather unhelpful when thrown from MatrixClient functions:
This doesn't really give away where the problem actually came from in the source. This PR does 3 things to resolve this:
doHttpRequest
directly, rather than inside the handler function for request. This reduces the amount of cruft in the stack trace. This did require a bit of rejiggling, and also fixed a bug introduced where non-JSON non-200 bodies would cause issues.The new stack traces look like:
Which while introduce a bit more cruft when several decorators are used in a chain, it also gives you a hint as to where the function call originated from.