Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on window to work in Web Workers #660

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Remove dependency on window to work in Web Workers #660

merged 3 commits into from
Dec 21, 2023

Conversation

rashyad
Copy link
Contributor

@rashyad rashyad commented Dec 11, 2023 •
edited by Acconut
Loading

Replace window in /lib/browser/index.js with self .

Fixes #658.

@rashyad rashyad mentioned this pull request Dec 11, 2023
Closed
@Acconut Acconut linked an issue Dec 11, 2023 that may be closed by this pull request
window is undefined when trying to run in worker file on browser #658
Closed
@Acconut Acconut changed the title Bugfix - replace window global with self Remove dependency on window to work in Web Workers Dec 21, 2023
@Acconut Acconut merged commit 2239aec into tus:main Dec 21, 2023
4 of 5 checks passed
@dumitrascuSorin dumitrascuSorin mentioned this pull request Jan 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

window is undefined when trying to run in worker file on browser
2 participants
@rashyad @Acconut