Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): split require-mark-placement and show-require-mark #1104

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

Volankey
Copy link
Collaborator

@Volankey Volankey commented Sep 6, 2021

NOTE: BREAKING CHANGE
close #1055.

@vercel
Copy link

vercel bot commented Sep 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/7icGAGX8Pf5UHeUBCmeept4n6g4V
✅ Preview: https://naive-ui-git-fork-volankey-form-require-mark-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1104 (56f4755) into main (3f71a7a) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 56f4755 differs from pull request most recent head 617f7b4. Consider uploading reports for the commit 617f7b4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   47.60%   47.50%   -0.11%     
==========================================
  Files         513      513              
  Lines       12668    12675       +7     
  Branches     3576     3578       +2     
==========================================
- Hits         6031     6021      -10     
- Misses       5618     5635      +17     
  Partials     1019     1019              
Impacted Files Coverage Δ
src/form/src/Form.tsx 29.41% <ø> (ø)
src/form/src/FormItem.tsx 33.07% <100.00%> (+3.14%) ⬆️
src/form/src/utils.ts 69.62% <100.00%> (+1.62%) ⬆️
src/gradient-text/src/GradientText.tsx 78.57% <0.00%> (-21.43%) ⬇️
src/image/src/Image.tsx 79.31% <0.00%> (-17.25%) ⬇️
src/image/src/ImageGroup.tsx 42.30% <0.00%> (-15.39%) ⬇️
src/image/src/ImagePreview.tsx 24.80% <0.00%> (-2.40%) ⬇️
src/radio/src/RadioGroup.tsx 1.51% <0.00%> (-0.13%) ⬇️
src/drawer/src/Drawer.tsx 58.13% <0.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f71a7a...617f7b4. Read the comment docs.

src/form/demos/enUS/index.demo-entry.md Outdated Show resolved Hide resolved
src/form/demos/enUS/index.demo-entry.md Outdated Show resolved Hide resolved
src/form/src/Form.tsx Outdated Show resolved Hide resolved
src/form/src/FormItem.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form split show-require-mark and require-mark-placement
3 participants