Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(n-tree): keyboard does not work when setting false #1509

Merged
merged 13 commits into from
Nov 3, 2021

Conversation

LYErin
Copy link
Contributor

@LYErin LYErin commented Nov 3, 2021

close #1508

@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/GL5o3E9CguczK6ZUgEmJ3mW7e37W
✅ Preview: https://naive-ui-git-fork-lyerin-fix-button-keyboard-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1509 (5d2f1e4) into main (6daf0ee) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   63.76%   63.75%   -0.01%     
==========================================
  Files         880      880              
  Lines       17089    17090       +1     
  Branches     4042     4042              
==========================================
  Hits        10896    10896              
- Misses       5462     5463       +1     
  Partials      731      731              
Impacted Files Coverage Δ
src/button/src/Button.tsx 77.85% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6daf0ee...5d2f1e4. Read the comment docs.

@XieZongChen
Copy link
Collaborator

有时间把历史commit清理一下
image

@07akioni 07akioni merged commit a28b09c into tusen-ai:main Nov 3, 2021
@LYErin LYErin deleted the fix-button-keyboard branch November 4, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NButton's keyboard="false" prop can't work independently
3 participants