Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): add shift prop to adjust position automatically #1663

Merged
merged 20 commits into from
Dec 30, 2021

Conversation

LYErin
Copy link
Contributor

@LYErin LYErin commented Nov 24, 2021

close #1520
close #1643

@vercel
Copy link

vercel bot commented Nov 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/6Sc3NqdQJrj4X4hpEQVJ6cDPxUNE
✅ Preview: https://naive-ui-git-fork-lyerin-optimize-vueuc-placement-tusimple.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2021

This pull request introduces 1 alert when merging 61e23fb into 088319f - view on LGTM.com

new alerts:

  • 1 for Duplicate property

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1663 (a0e1ff4) into main (8b29dba) will not change coverage.
The diff coverage is n/a.

❗ Current head a0e1ff4 differs from pull request most recent head b08c353. Consider uploading reports for the commit b08c353 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files         899      899           
  Lines       17620    17620           
  Branches     4174     4174           
=======================================
  Hits        11396    11396           
  Misses       5437     5437           
  Partials      787      787           
Impacted Files Coverage Δ
src/popover/src/Popover.tsx 64.70% <ø> (ø)
src/popover/src/PopoverBody.tsx 71.95% <ø> (ø)
src/popover/src/styles/index.cssr.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c71424...b08c353. Read the comment docs.

@LYErin LYErin force-pushed the optimize-vueuc-placement branch from 30139ce to a8da9ce Compare December 30, 2021 08:09
@LYErin LYErin changed the title feat(popover): add fliplevel to adjust position automatically feat(popover): add shift prop to adjust position automatically Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover 组件的filp Menu does not adjust position automatically if it'll be hidden by a browser edge
2 participants