Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): expose trigger-click-on-close prop #3352

Merged
merged 5 commits into from
Jul 30, 2022
Merged

Conversation

Sepush
Copy link
Collaborator

@Sepush Sepush commented Jul 26, 2022

Signed-off-by: Sepush [email protected]

close #3343

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
naive-ui ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 3:51PM (UTC)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #3352 (215b99e) into main (0345380) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 215b99e differs from pull request most recent head c6f46df. Consider uploading reports for the commit c6f46df to get more accurate results

@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
- Coverage   63.14%   63.06%   -0.09%     
==========================================
  Files        1048     1048              
  Lines       21761    21783      +22     
  Branches     5651     5666      +15     
==========================================
- Hits        13742    13737       -5     
- Misses       6556     6571      +15     
- Partials     1463     1475      +12     
Impacted Files Coverage Δ
src/_internal/selection/src/Selection.tsx 40.44% <ø> (-0.89%) ⬇️
src/tag/src/Tag.tsx 64.70% <100.00%> (+2.94%) ⬆️
src/watermark/src/Watermark.tsx 44.57% <0.00%> (-6.86%) ⬇️
src/_internal/select-menu/src/SelectMenu.tsx 60.54% <0.00%> (-4.09%) ⬇️
src/dialog/src/DialogEnvironment.tsx 45.00% <0.00%> (-3.65%) ⬇️
src/carousel/src/Carousel.tsx 62.55% <0.00%> (-0.91%) ⬇️
src/locales/common/deDE.ts 40.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0345380...c6f46df. Read the comment docs.

@07akioni
Copy link
Collaborator

这个名字不太好,stopClickPropagation 是阻止 click 的传递。

叫 trigger-click-on-close 吧

@Sepush Sepush changed the title feat(tag): expose stop-click-propagation prop feat(tag): expose trigger-click-on-close prop Jul 27, 2022
@07akioni 07akioni merged commit d6b5cd3 into tusen-ai:main Jul 30, 2022
@Sepush Sepush deleted the issue3343 branch July 31, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag标签绑定click事件时,点击tag标签的关闭按钮时会同时触发close事件
2 participants