-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): filter break bug #756
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -713,7 +713,7 @@ export default defineComponent({ | |
} | ||
loading={this.loading} | ||
focused={this.focused} | ||
onClick={this.handleTriggerClick} | ||
onMousedown={this.handleTriggerClick} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这块处理不能这么简单,得理一下逻辑,mousedown 干的事和 click 应该是有一些区别的。 如果有必要的话需要重新分配一下。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mousedown 可以触发 openMenu,focus 不能。 要注意各种 filter + multiple 的组合不要出问题,以及按 tab focus 的状态不要受影响。 |
||
onDeleteOption={this.handleToggleOption} | ||
onPatternInput={this.handlePatternInput} | ||
onClear={this.handleClear} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是每一个 mousedown 都要和 click 走一样的逻辑,这块的处理感觉不太行。