Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timeline): add horizontal prop #932

Merged
merged 5 commits into from
Aug 22, 2021
Merged

feat(timeline): add horizontal prop #932

merged 5 commits into from
Aug 22, 2021

Conversation

doom-9-zz
Copy link
Contributor

close #887

@vercel
Copy link

vercel bot commented Aug 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/HzNEvM36TeorsAA3LH798VULYqbD
✅ Preview: https://naive-ui-git-fork-doom-9-feattimeline-add-horiz-b64154-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Aug 21, 2021 •
edited
Loading

Codecov Report

Merging #932 (5b737c1) into main (4aabd2a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5b737c1 differs from pull request most recent head 0fb4349. Consider uploading reports for the commit 0fb4349 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   44.63%   44.64%           
=======================================
  Files         509      509           
  Lines       12461    12463    +2     
  Branches     3501     3503    +2     
=======================================
+ Hits         5562     5564    +2     
  Misses       5898     5898           
  Partials     1001     1001
Impacted Files Coverage Δ
src/timeline/src/Timeline.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aabd2a...0fb4349. Read the comment docs.

@XieZongChen
Copy link
Collaborator

  1. 感觉 horizontal 加在当前的 prop 上不是很好
  2. 加一下测试

@07akioni
Copy link
Collaborator

加一个 Demo，现在 vercel 的 preview 看不出来功能

07akioni
07akioni reviewed Aug 21, 2021
View reviewed changes
src/timeline/demos/enUS/index.demo-entry.md Outdated
| size | `'medium' \| 'large'` | `'medium'` | Size. |
| Name | Type | Default | Description |
| --- | --- | --- | --- |
| item-placement | `'left' \| 'right' \| 'horizontal'` | `'left'` | Direction. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horizontal 单独开一个 prop 吧

@doom-9-zz doom-9-zz changed the title feat(timeline): item-placement add horizontal prop feat(timeline): add horizontal prop Aug 22, 2021
@07akioni 07akioni merged commit 3d2736f into tusen-ai:main Aug 22, 2021
rhengles pushed a commit to arijs/naive-ui that referenced this pull request Oct 20, 2021
@doom-9-zz @07akioni @rhengles
feat(timeline): add horizontal prop (tusen-ai#932)
2b8b38d 
* feat(timeline): `item-placement` add `horizontal` prop

* feat: fix code

* feat: add test

* feat: fix code

* Apply suggestions from code review

Co-authored-by: 07akioni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07akioni 07akioni 07akioni left review comments

@XieZongChen XieZongChen XieZongChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeline组件我想要横向显示的，目前只支持纵向显示的
4 participants
@doom-9-zz @XieZongChen @07akioni @doom-9