Remove scrollbar #29
Open
Remove scrollbar #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ninadnaik10 Thank you for opening this PR. PS: Try your deployed PR here: https://deploy-preview-29--tusharjustdoit.netlify.app So, implementing a fix like this or what was done earlier; is like hiding the problem, rather than fixing it. Thank you for bringing this to my notice. Will be reopening #22 and the fix is to always have a scrollbar fixed. So, the screen doesn't shrink — when the scrollbar appears. Would you like to work on this PR? |
|
Hi @tusharnankani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when deleting a task, the task falls and scrollbar appears. The scrollbar shrinks the page for a moment which does not look good. So I hid it from the body tag. I know this approach is not good for accessibility but it would help the webpage look nicer.