Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom emojis are forced to a square aspect ratio #635

Closed
1 task done
ashkitten opened this issue May 7, 2018 · 5 comments · Fixed by #3711
Closed
1 task done

Custom emojis are forced to a square aspect ratio #635

ashkitten opened this issue May 7, 2018 · 5 comments · Fixed by #3711
Labels

Comments

@ashkitten
Copy link

ashkitten commented May 7, 2018

Emojis like :oh_no: from dev.glitch.social are squished to a square aspect ratio, whereas the web client leaves them as is and only scales to a certain height.

e76a15d45f7d8512


  • Tusky Version: 1.7.0

  • Android Version: 8.1.0

  • Android Device: Google Pixel XL

  • Mastodon instance (if applicable): dev.glitch.social

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@charlag
Copy link
Collaborator

charlag commented May 7, 2018

Thanks for reporting! Cannot say how hard it is to fix right now but I think it's possible

@connyduck
Copy link
Collaborator

The problem with this is, we cannot know the size of the emoji prior to loading it, so the text will reformat when the emoji does not have square aspect ratio with could cause the whole layout to jump. This could get really ugly and I would rather not support any other aspect ratio than having this.

@charlag
Copy link
Collaborator

charlag commented Jul 2, 2018

Hmm, we can invalidating anyway after loading but as I remember intrinsic size was too small so I just hardcoded the size. It's totally possible to write a thing which will figure appropriate size but it's not really high priority

@Tak
Copy link
Collaborator

Tak commented Jan 27, 2019

@ashkitten
Copy link
Author

can we at least maintain aspect ratio and center them within the square?

nikclayton pushed a commit that referenced this issue Jun 11, 2023
Instead of forcing all emojis to be square, only the width is fixed now and the emoji scaled to fit.

Fixes #635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants