Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3419 alt text in any case #3421

Merged
merged 12 commits into from
Apr 24, 2023
Merged

3419 alt text in any case #3421

merged 12 commits into from
Apr 24, 2023

Conversation

Lakoja
Copy link
Collaborator

@Lakoja Lakoja commented Mar 7, 2023

Fixes #3419

@Lakoja Lakoja force-pushed the 3419-alt-text-in-any-case branch from 230ed4b to e9cf231 Compare March 22, 2023 13:31
@Lakoja
Copy link
Collaborator Author

Lakoja commented Mar 24, 2023

Regarding the current linter error:

Error: "error_failed_set_caption" is translated here but not found in default locale

That is correct as I removed it.

Should/must I remove it from all others as well?
(Or is that done "automatically" once any translation is updated by a translator?)

@connyduck
Copy link
Collaborator

Once this is merged, Weblate should send a PR to remove it from everywhere, yes. But I can't merge because lint is complaining 🙄
I could bypass the merge block, but I'd prefer it if you removed it everywhere.

@Lakoja Lakoja force-pushed the 3419-alt-text-in-any-case branch from 00f34ea to ce08c80 Compare March 30, 2023 19:10
@connyduck
Copy link
Collaborator

Should be good to go if you resolve the conflicts

@Lakoja Lakoja force-pushed the 3419-alt-text-in-any-case branch from ce08c80 to 270b9c0 Compare April 20, 2023 18:30
@Lakoja
Copy link
Collaborator Author

Lakoja commented Apr 20, 2023

Should be good to go if you resolve the conflicts

Done.

It doesn't seem to be a good idea to remove / change things in other files than the default strings.xml.
That was a lot of work now. And lots of conflicts repeatedly...

@nikclayton nikclayton merged commit 24d7ef7 into tuskyapp:develop Apr 24, 2023
@Lakoja Lakoja deleted the 3419-alt-text-in-any-case branch April 24, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcclure mcclure mcclure left review comments

@connyduck connyduck connyduck left review comments

@Tak Tak Tak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow image upload: alt text will be deleted
5 participants
@Lakoja @connyduck @Tak @mcclure @nikclayton